[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140410135433.GH8488@redhat.com>
Date: Thu, 10 Apr 2014 09:54:33 -0400
From: Don Zickus <dzickus@...hat.com>
To: Jiri Olsa <jolsa@...hat.com>
Cc: acme@...stprotocols.net, LKML <linux-kernel@...r.kernel.org>,
namhyung@...il.com
Subject: Re: [PATCH 1/4 v2] perf: Allow ability to map cpus to nodes easily
On Thu, Apr 10, 2014 at 03:24:58PM +0200, Jiri Olsa wrote:
> On Thu, Apr 10, 2014 at 09:15:15AM -0400, Don Zickus wrote:
> > On Thu, Apr 10, 2014 at 11:31:46AM +0200, Jiri Olsa wrote:
> > > On Mon, Apr 07, 2014 at 02:55:21PM -0400, Don Zickus wrote:
> > >
> > > SNIP
> > >
> > > > +static int init_cpunode_map(void)
> > > > +{
> > > > + int i;
> > > > +
> > > > + set_max_cpu_num();
> > > > + set_max_node_num();
> > > > +
> > > > + cpunode_map = calloc(max_cpu_num, sizeof(int));
> > > > + if (!cpunode_map) {
> > > > + pr_err("%s: calloc failed\n", __func__);
> > > > + goto out;
> > > shuld probably be ^^^:
> > >
> > > return -1;
> > >
> > > > + }
> > > > +
> > > > + for (i = 0; i < max_cpu_num; i++)
> > > > + cpunode_map[i] = -1;
> > > > +
> > > > + return 0;
> > > > +out:
> > > > + return -1;
> > >
> > > and remove 'out' label code
> >
> > Sorry, probably leftover code that after snipping and changing didn't get
> > noticed. Thanks.
> >
> > >
> > > other than that, it seems ok.. I'll queue it
> >
> > I assume you are making the changes locally or should I resubmit?
>
> yes, I'll do that localy
Thanks!
Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists