[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <C97001BC43954D438ACB059713BA5CDF92040F0F0C@USEA-EXCH7.na.uis.unisys.com>
Date: Thu, 10 Apr 2014 09:56:42 -0500
From: "Romer, Benjamin M" <Benjamin.Romer@...sys.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: *S-Par-Maintainer <SParMaintainer@...sys.com>,
"jkc@...hat.com" <jkc@...hat.com>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] unisys: staging: Check for s-Par firmware before
initializing s-Par modules
On Wed, 2014-04-09 at 12:25 -0700, Greg Kroah-Hartman wrote:
> Patches need to do only one thing, so can you please split this up in to
> multiple patches, each one only doing one thing.
Sorry about that! I'll send another patch that fixes all of the
copyright statements at once then. :)
> You forgot to add a "Reported-by:" line here, and possibly a
> "Tested-by:" if someone tested it and reported that it solved the
> problem. Proper attribution is very important.
Will do! Thanks for all the feedback. I'll rework my patch. :)
-- Ben
Powered by blists - more mailing lists