linux-kernel - Re: [PATCH] gpio / ACPI: Prevent potential wrap of GPIO value on OpRegion read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYfWsBqZenG8y7jYo1QzKpBdaFRe=ne4-1Lr2RgoDpNGg@mail.gmail.com>
Date:	Thu, 10 Apr 2014 18:24:18 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio / ACPI: Prevent potential wrap of GPIO value on
 OpRegion read

On Tue, Apr 1, 2014 at 12:03 PM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:

> Dan Carpenter's static code checker reports:
>
>  The patch 473ed7be0da0: "gpio / ACPI: Add support for ACPI GPIO
>  operation regions" from Mar 14, 2014, leads to the following static
>  checker warning:
>
>   drivers/gpio/gpiolib-acpi.c:454 acpi_gpio_adr_space_handler()
>   warn: should 'gpiod_get_raw_value(desc) << i' be a 64 bit type?
>
> This is due the fact that *value is of type u64 and gpiod_get_raw_value()
> returns int. Since i can be larger than 31, it is possible that the value
> returned gets wrapped.
>
> Fix this by casting the return of gpiod_get_raw_value() to u64 first before
> shift.
>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Patch applied for fixes.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/