linux-kernel - Re: 3.14.0+/x86: lockdep and mutexes not getting along

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Apr 2014 19:26:52 -0400
From:	Dave Jones <davej@...hat.com>
To:	Jason Low <jason.low2@...com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	"Michael L. Semon" <mlsemon35@...il.com>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com
Subject: Re: 3.14.0+/x86: lockdep and mutexes not getting along

On Thu, Apr 10, 2014 at 10:14:44AM -0700, Jason Low wrote:
 > On Thu, 2014-04-10 at 11:18 +0200, Peter Zijlstra wrote:
 > > On Wed, Apr 09, 2014 at 10:42:59PM -0700, Jason Low wrote:
 > > > As a starting point, would either of you like to test the following
 > > > patch to see if it fixes the issue? This patch essentially generates the
 > > > same code as in older kernels in the debug case. This applies on top of
 > > > kernels with both commits 6f008e72cd11 and 1d8fe7dc8078.
 > > 
 > > 
 > > So I managed to reproduce, and the below makes it go away. I just don't
 > > understand why though. will stare more.
 > 
 > So one thing I noticed that is different in the current code is that in
 > debug_mutex_unlock(), there is is a possibility that it does not unlock
 > the mutex (when !debug_locks). May be interesting to try out this
 > patch too:
 
I've been seeing lockups this last week or two too, that manifested by
RCU spewing stall messages, and the box being totally unresponsive.
This patch seems to cure that for me, which I'm sure will make Paul
happy to hear.

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/