lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Apr 2014 14:53:21 +0800 From: <rogerable@...ltek.com> To: Samuel Ortiz <sameo@...ux.intel.com>, Lee Jones <lee.jones@...aro.org>, Chris Ball <chris@...ntf.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Maxim Levitsky <maximlevitsky@...il.com>, Alex Dubov <oakad@...oo.com>, Dan Carpenter <dan.carpenter@...cle.com>, Ulf Hansson <ulf.hansson@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, Oliver Neukum <oneukum@...e.de> CC: <rogerable@...ltek.com>, <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>, <driverdev-devel@...uxdriverproject.org>, <wei_wang@...lsil.com.cn>, <micky_ching@...lsil.com.cn> Subject: [PATCH v7 2/4] [v6 fix] mfd/rtsx_usb: add comment in rtsx_usb_suspend From: Roger Tseng <rogerable@...ltek.com> Explain why there is no need to have a symmetric LED turn-on in resume handler while calling rtsx_usb_turn_off_led() in suspend handler. Signed-off-by: Roger Tseng <rogerable@...ltek.com> --- drivers/mfd/rtsx_usb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c index 0ca7973..141ea52 100644 --- a/drivers/mfd/rtsx_usb.c +++ b/drivers/mfd/rtsx_usb.c @@ -687,9 +687,15 @@ static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message) dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n", __func__, message.event); + /* + * Call to make sure LED is off during suspend to save more power. + * It is NOT a permanent state and could be turned on anytime later. + * Thus no need to call turn_on when resunming. + */ mutex_lock(&ucr->dev_mutex); rtsx_usb_turn_off_led(ucr); mutex_unlock(&ucr->dev_mutex); + return 0; } -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists