linux-kernel - Re: [PATCH] i2c: busses: ali1563: fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140411112156.5e7e32c2@endymion.delvare>
Date:	Fri, 11 Apr 2014 11:21:56 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Richard Leitner <me@...l1n.net>
Cc:	r.marek@...embler.cz, wsa@...-dreams.de, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: busses: ali1563: fix checkpatch.pl issues

Hi Richard,

On Thu, 10 Apr 2014 19:28:44 +0200, Richard Leitner wrote:
> Fixed most checkpatch.pl issues

Thanks for doing this. Overall it looks good, there are just two
warnings I would like fixed slightly differently:

> @@ -268,13 +272,14 @@ static s32 ali1563_access(struct i2c_adapter * a, u16 addr,
>  	}
>  
>  	outb_p(((addr & 0x7f) << 1) | (rw & 0x01), SMB_HST_ADD);
> -	outb_p((inb_p(SMB_HST_CNTL2) & ~HST_CNTL2_SIZEMASK) | (size << 3), SMB_HST_CNTL2);
> +	outb_p((inb_p(SMB_HST_CNTL2) & ~HST_CNTL2_SIZEMASK) |
> +			(size << 3), SMB_HST_CNTL2);

Please align on the opening parenthesis.

> @@ -392,14 +398,15 @@ static struct i2c_adapter ali1563_adapter = {
>  static int ali1563_probe(struct pci_dev *dev,
>  			 const struct pci_device_id *id_table)
>  {
> -	int error;
> +	int error = ali1563_setup(dev);
>  
> -	if ((error = ali1563_setup(dev)))
> +	if (error)
>  		goto exit;

Please leave the variable declaration alone, so that the error check
can immediately follow the assignment, as was the case before. Anyway
it is not recommended to run "real code" during variable declaration.

With these changes applied, feel free to add:

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/