linux-kernel - Re: [PATCH v2] perf list: Fix --raw-dump argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140411103253.GA1107@krava.brq.redhat.com>
Date:	Fri, 11 Apr 2014 12:32:53 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Ramkumar Ramachandra <artagnon@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v2] perf list: Fix --raw-dump argument

On Thu, Apr 10, 2014 at 08:42:33PM -0400, Ramkumar Ramachandra wrote:
> While adding usage information, 44d742e (perf list: Add usage,
> 2013-10-30) broke
> 
>   $ perf list --raw-dump
> 
> Fix this by making raw-dump a subcommand.

you need to update perf-completion.sh now
also please add it to perf list man page as well

thanks,
jirka

> 
> Cc: David Ahern <dsahern@...il.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Signed-off-by: Ramkumar Ramachandra <artagnon@...il.com>
> ---
>  tools/perf/builtin-list.c     | 2 +-
>  tools/perf/perf-completion.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 011195e..c74aef5 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -53,7 +53,7 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
>  			print_hwcache_events(NULL, false);
>  		else if (strcmp(argv[i], "pmu") == 0)
>  			print_pmu_events(NULL, false);
> -		else if (strcmp(argv[i], "--raw-dump") == 0)
> +		else if (strcmp(argv[i], "raw-dump") == 0)
>  			print_events(NULL, true);
>  		else {
>  			char *sep = strchr(argv[i], ':'), *s;
> diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
> index ae3a576..8f518f0 100644
> --- a/tools/perf/perf-completion.sh
> +++ b/tools/perf/perf-completion.sh
> @@ -119,7 +119,7 @@ __perf_main ()
>  		fi
>  	# List possible events for -e option
>  	elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then
> -		evts=$($cmd list --raw-dump)
> +		evts=$($cmd list raw-dump)
>  		__perfcomp_colon "$evts" "$cur"
>  	# List subcommands for 'perf kvm'
>  	elif [[ $prev == "kvm" ]]; then
> -- 
> 1.9.2.667.ge5b74e1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/