linux-kernel - Re: [PATCH 02/15] arm: __NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140411103351.GJ16119@n2100.arm.linux.org.uk>
Date:	Fri, 11 Apr 2014 11:33:51 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Miklos Szeredi <mszeredi@...e.cz>
Subject: Re: [PATCH 02/15] arm: __NR_syscalls fix

On Fri, Apr 11, 2014 at 12:25:38PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> Cc: Russell King <linux@....linux.org.uk>
> ---

This has me wondering...

(a) what you think it fixes
(b) whether you tried to build-test this

The ARM instruction set supports 8-bit immediate constants with an even
power of two shift.  384 fits that (0x180), 382 does not (0x17e), and
in your following patch, 383 definitely doesn't (0x17f).

Having this constant larger than necessary does not cause any problem
for the syscall table: we explicitly pad it with calls to sys_ni_syscall
to make up the difference.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/