linux-kernel - Re: [PATCH] initramfs: remove "compression mode" choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.10.1404111807030.13489@wniryva.cad.erqung.pbz>
Date:	Fri, 11 Apr 2014 18:25:55 +0530 (IST)
From:	P J P <ppandit@...hat.com>
To:	Michael Fyles <mf@...ston.net>
cc:	linux-kernel@...r.kernel.org, Paul Bolle <pebolle@...cali.nl>
Subject: Re: [PATCH] initramfs: remove "compression mode" choice

   Hello Michael,

+-- On Fri, 11 Apr 2014, Paul Bolle wrote --+
| On Fri, 2014-04-11 at 12:26 +0100, Michael Fyles wrote:
| > Commit 9ba4bcb64589 mistakenly forced the logic in usr/Makefile
| > to prioritise the selection of RD options such that selecting
| > more than one supported compression pretty much rail-roads you
| > into having your initrd compressed with gzip. This happends
| > because because suffix-y gets updated once for each supported
| > compression and, by default (on x86, at least) all compressions
| > are supported.

   IIUC, that's not because of the commit. Even earlier it was the same. 
Because that's how Makefile reads and updates the variables. Now that .gzip is 
listed last in the make file, it defaults to .gzip when all options are set. 
Otherwise it would default to .lz4  or .lzo before lz4 was introduced.

   See -> https://lkml.org/lkml/2013/12/23/170

| > If 1 is chosen, it would be advantageous to have RD as a
| > mutually-exclusive choice -- this would be the place to put all
| > the help texts that your patch removes.
| > 
| > I currently have a patch that performs 2, if you decide that
| > might be better.

   I don't get it. You mean one option for build time compression and another 
for run time compression? Shouldn't those two be exactly same?

--
  - P J P
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/