linux-kernel - Re: [PATCH] staging: wlan-ng: fix bad symbol declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140411134104.GA29002@leaf>
Date:	Fri, 11 Apr 2014 06:41:05 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Neil Armstrong <superna9999@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Himangi Saraogi <himangi774@...il.com>,
	Tugce Sirin <ztugcesirin@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix bad symbol declaration

On Fri, Apr 11, 2014 at 03:00:49PM +0200, Neil Armstrong wrote:
> With sparse, the following error appears :
>   CHECK   drivers/staging/wlan-ng/p80211netdev.c
> drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?
> 
> Move functions declaration to coherent internal header file.
> 
> Signed-off-by: Neil 'Superna' Armstrong <superna9999@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/staging/wlan-ng/prism2mgmt.h |    5 +++++
>  drivers/staging/wlan-ng/prism2sta.c  |    4 ----
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 190d390..b62fdcb 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -109,4 +109,9 @@ void prism2sta_processing_defer(struct work_struct *data);
>  void prism2sta_commsqual_defer(struct work_struct *data);
>  void prism2sta_commsqual_timer(unsigned long data);
>  
> +/* Interface callback functions, passing data back up to the cfg80211 layer */
> +void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> +void prism2_disconnected(wlandevice_t *wlandev);
> +void prism2_roamed(wlandevice_t *wlandev);
> +
>  #endif
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index f9ccf23..3fd4538 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -120,10 +120,6 @@ MODULE_PARM_DESC(prism2_reset_settletime, "reset settle time in ms");
>  
>  MODULE_LICENSE("Dual MPL/GPL");
>  
> -void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> -void prism2_disconnected(wlandevice_t *wlandev);
> -void prism2_roamed(wlandevice_t *wlandev);
> -
>  static int prism2sta_open(wlandevice_t *wlandev);
>  static int prism2sta_close(wlandevice_t *wlandev);
>  static void prism2sta_reset(wlandevice_t *wlandev);
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/