lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20140411145524.6fbda7bb@gandalf.local.home>
Date:	Fri, 11 Apr 2014 14:55:24 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc:	namhyung.kim@....com, linux-kernel@...r.kernel.org
Subject: Re: ftrace: reading set_graph_notrace returns "#### all functions
 enabled ####"

On Fri, 11 Apr 2014 14:24:17 -0400
Naoya Horiguchi <n-horiguchi@...jp.nec.com> wrote:

> Hi,
> 
> I report a minor issue of set_graph_notrace.
> The default value of set_graph_notrace is void (so no function is excluded,)
> but when we read the file, we get "#### all functions enabled ####" like below:
> 
>   [root@...t tracing]# echo "" > set_graph_notrace
>   [root@...t tracing]# cat set_graph_notrace
>   #### all functions enabled ####
> 
> This does not happen for set_ftrace_notrace:
> 
>   [root@...t tracing]# echo "" > set_ftrace_notrace
>   [root@...t tracing]# cat set_ftrace_notrace
>   [root@...t tracing]#
> 
> This is not critical but confusing, so it would be nice if fixed.

Ah, I would say they both are wrong. The set_graph_notrace is rather
new, and probably copied and pasted incorrectly.

But having nothing printed may not be the best thing to show. I think
both should be switched to

#### no functions disabled ####

But this can be done in my 3.16 queue.

Thanks for the report,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ