linux-kernel - Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1954196.dS1rBRHUqX@myon.chronox.de>
Date:	Fri, 11 Apr 2014 21:24:17 +0200
From:	Stephan Mueller <smueller@...onox.de>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	aquini@...hat.com, jeremy.wayne.powell@...il.com,
	clemens@...isch.de, pwalten@....ibm.com
Subject: Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

Am Freitag, 11. April 2014, 11:20:21 schrieb Joe Perches:

Hi Joe,

> 
> It looks like const could be used a bit more often.
> 
> For instance:
> perhaps uses of key could be changed to const unsigned char *key
 
Good point. I will try to find areas where const can be used. However, due to 
the use of a linked list approach with struct drbg_string, using const will 
remain limited.

Ciao
Stephan
-- 
| Cui bono? |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/