linux-kernel - Re: [GIT PULL] spi fixes for v3.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140411214704.GH28800@sirena.org.uk>
Date:	Fri, 11 Apr 2014 22:47:04 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-spi@...r.kernel.org
Subject: Re: [GIT PULL] spi fixes for v3.15

On Fri, Apr 11, 2014 at 01:41:56PM -0700, Linus Torvalds wrote:
> On Fri, Apr 11, 2014 at 3:56 AM, Mark Brown <broonie@...nel.org> wrote:

> > Same issue as on the regulator pull request with the entire diffstat for
> > the original pull request for this merge window has appeared - like I
> > say I will try to fix the scripts as it's annoying and unclear.

> Yeah, looking at this, the problem does seem to be that extraneous
> merge. I'm not sure why you did that "Merge tag 'spi-v3.15' into
> spi-linus" at all, but it basically acts as an indirect back-merge
> giving you two different merge bases.

Indeed.

> You seem to start your development by doing a merge of that tag that
> you sent me. Why? Why not just start *at* the tag you sent me, not at
> that extraneous merge of that tag and v3.14.

What the script is doing is starting from your latest tag, merging any
tags I've sent you in the meantime and then merging any additional topic
branches.  I'm not doing any actual development on the resulting branch,
only on topic branches.  The tags get merged first to suppress repeated
merges of the same topic branch if I've sent a prior pull request been
tagged yet and I use your latest tag to pick up fixes from other trees
and make sure I'm not tripping over things I sent you before.

Usually this works fine since most of the time either your latest tag
contains the last thing I sent you or my tag contains your most recent
tag and either way there's no back merge.  What's gone wrong this time
around is that I sent you my initial pull requests based off the last
-rc rather than off the release tag, the script didn't cope well with
that and picked the wrong thing to base the merge off.

If I'd respun the merge before I sent the pull requests it'd all be
working as expected, I need to either just do that or teach the script
to be more sensible about picking where it starts building the merge
from.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)