linux-kernel - Re: [PATCH] fwserial: (unexhaustive) coding style review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2014 18:04:11 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dominique van den Broeck <domdevlin@...e.fr>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fwserial: (unexhaustive) coding style review

On Sat, Apr 12, 2014 at 01:41:01AM +0200, Dominique van den Broeck wrote:
> From: Dominique van den Broeck <domdevlin@...e.fr>
> fwserial: (unexhaustive) coding style review

No need for the From: line here, or the extra subject line.

> 
> linux-next commit 88a8e0969581869c742a9957ddcfe43063dff687 

This isn't needed either.

> 
> Style-only modifications to make checkpatch.pl --file --strict a bit
> happier.
> I fixed only what was trivial, such as parenthesis alignments (one of
> them,
> at fwserial.c:1349, couldn't be easily replaced by something better,
> though).
> However, I did not comment by myself issues regarding spinlocks or
> memory
> barriers.

Odd linewrapping.

> 
> This is my very first patch. Please be indulgent and forgive my eventual
> mistakes. I did that to start contributing to linux kernel, but also
> as task #10 of the Eudyptula Challenge ( http://eudyptula-challenge.org/
> ).

This isn't needed at all, don't put it in the changelog area.


> 
> Signed-off-by: Dominique van den Broeck <domdevlin@...e.fr>
> ---
> diff -upr a/drivers/staging/fwserial/dma_fifo.c
> b/drivers/staging/fwserial/dma_fifo.c
> --- a/drivers/staging/fwserial/dma_fifo.c	2014-04-11 20:48:20.813667706
> +0200
> +++ b/drivers/staging/fwserial/dma_fifo.c	2014-04-11 20:47:49.700058306
> +0200

The patch is line-wrapped and can't be applied :(

> @@ -12,10 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> Foundation,
> - * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
>   */

You are fixing a lot of different things here.  Patches need to do only
one thing at a time.  For different coding style cleanups, do it one
patch per "thing", and this will be a few patches at the least.

So, can you fix this all up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/