linux-kernel - Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1397424375.31896.7.camel@x220>
Date:	Sun, 13 Apr 2014 23:26:15 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Pascal COMBES <pascom@...nge.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Jarod Wilson <jarod@...sonet.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Valentina Manea <valentina.manea.m@...il.com>,
	linux-kernel@...r.kernel.org, Naren Sankar <nsankar@...adcom.com>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Scott Davilla <davilla@....com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Robert Foss <dev@...ertfoss.se>
Subject: Re: [PATCH v2 1/3] Fix alignement problems in
 drivers/staging/crystalhd/crystalhd_lnx.c

On Mon, 2014-04-14 at 00:02 +0300, Dan Carpenter wrote:
> The subeject should be:
> 
> [PATCH v2 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c
> 
> Please resend it.  Also you should use shorter subject lines.
> 
> "Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c"
> 
> This is too long.  Say:
> 
> "Remove a stray space character in crystalhd_lnx.c"

The commit explanation also was a copy of the subject line. That
suggests that the explanation can be dropped. Many trivial fixes can
(and should) be submitted without a commit explanation.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/