linux-kernel - Re: [PATCH 1/7] f2fs: put the bio when issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1397439375.24638.20.camel@kjgkr>
Date:	Mon, 14 Apr 2014 10:36:15 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Gu Zheng <guz.fnst@...fujitsu.com>
Cc:	f2fs <linux-f2fs-devel@...ts.sourceforge.net>,
	fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] f2fs: put the bio when issue_flush completed

Hi Gu,
Merged.
thank you. :)

2014-04-11 (금), 17:49 +0800, Gu Zheng:
> Put the bio when the flush cmd issued, it also can fix the following
> kmemleak:
> unreferenced object 0xffff8800270c73c0 (size 200):
>   comm "f2fs_flush-7:0", pid 27161, jiffies 4312127988 (age 988.503s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 40 07 81 19 01 88 ff ff  ........@.......
>     01 00 00 00 00 00 00 f0 11 14 00 00 00 00 00 00  ................
>   backtrace:
>     [<ffffffff81559866>] kmemleak_alloc+0x72/0x96
>     [<ffffffff81156f7e>] slab_post_alloc_hook+0x28/0x2a
>     [<ffffffff811595b1>] kmem_cache_alloc+0xec/0x157
>     [<ffffffff8111924d>] mempool_alloc_slab+0x15/0x17
>     [<ffffffff81119513>] mempool_alloc+0x71/0x138
>     [<ffffffff81193548>] bio_alloc_bioset+0x93/0x18c
>     [<ffffffffa040f857>] issue_flush_thread+0x8d/0x145 [f2fs]
>     [<ffffffff8107ac16>] kthread+0xba/0xc2
>     [<ffffffff81571b2c>] ret_from_fork+0x7c/0xb0
>     [<ffffffffffffffff>] 0xffffffffffffffff
> 
> Signed-off-by: Gu Zheng <guz.fnst@...fujitsu.com>
> ---
>  fs/f2fs/segment.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 085f548..524b7ed 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -226,6 +226,7 @@ repeat:
>  			next = cmd->next;
>  			complete(&cmd->wait);
>  		}
> +		bio_put(bio);
>  		sm_i->dispatch_list = NULL;
>  	}
>  

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/