linux-kernel - Re: [PATCH v3 3/5] x86: fix list corruption on CPU hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 12:48:38 +0200
From:	Igor Mammedov <imammedo@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, bp@...e.de,
	paul.gortmaker@...driver.com, JBeulich@...e.com, prarit@...hat.com,
	drjones@...hat.com, toshi.kani@...com, riel@...hat.com,
	gong.chen@...ux.intel.com, andi@...stfloor.org, lenb@...nel.org,
	rjw@...ysocki.net, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v3 3/5] x86: fix list corruption on CPU hotplug

On Mon, 14 Apr 2014 12:34:13 +0200
Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Igor Mammedov <imammedo@...hat.com> wrote:
> 
> > On Mon, 14 Apr 2014 12:04:57 +0200
> > Ingo Molnar <mingo@...nel.org> wrote:
> > 
> > > 
> > > * Igor Mammedov <imammedo@...hat.com> wrote:
> > > 
> > > > On Mon, 14 Apr 2014 11:19:54 +0200
> > > > Ingo Molnar <mingo@...nel.org> wrote:
> > > > 
> > > > > 
> > > > > * Igor Mammedov <imammedo@...hat.com> wrote:
> > > > > 
> > > > > > currently if AP wake up is failed, master CPU marks AP as not present
> > > > > > in do_boot_cpu() by calling set_cpu_present(cpu, false).
> > > > > > That leads to following list corruption on the next physical CPU
> > > > > > hotplug:
> > > > > 
> > > > > Shouldn't this fix precede the main change to the smp bootup logic?
> > > > > 
> > > > > Can this bug trigger with current upstream kernels?
> > > > That's not impossible, tests showed that with current kernel there will
> > > > be other problems due wild AP running around.
> > > > 
> > > > I'll reorder patch anyway.
> > > 
> > > So, could you please first make sure that with only the fixes applied 
> > > there's no problems left?
> >
> > Sure, I'll retest reordered series.
> 
> Please don't jus test a reodered series, but a 'fixes only' series, 
> which does not include patch #1.
>
Yep, that's  ^^^ what I've meant to do, I'm sorry for not being clear enough.
I'll check that bugs, that patches fix, are fixed and they don't break
something else except of issues #1 fixes of cause.
 
> We will apply that patch too, to improve the bootup of virtualized 
> environments, but we first want to know whether the 'baseline' is OK 
> and fixed 100%.
> 
> Thanks,
> 
> 	Ingo


-- 
Regards,
  Igor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/