linux-kernel - Re: [PATCH] tools: Consolidate types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140414111805.GA7696@krava.brq.redhat.com>
Date:	Mon, 14 Apr 2014 13:18:05 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Rusty Russell <rusty@...tcorp.com.au>,
	LKML <linux-kernel@...r.kernel.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	virtio-dev@...ts.oasis-open.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] tools: Consolidate types.h

On Sun, Apr 13, 2014 at 01:27:43PM +0200, Borislav Petkov wrote:
> And while we're at it, let's do another consolidation:
> 
> ---
> From: Borislav Petkov <bp@...e.de>
> Date: Sat, 12 Apr 2014 20:10:49 +0200
> Subject: [PATCH] tools: Consolidate types.h
> 
> Combine all definitions into a common tools/include/linux/types.h and
> kill the wild growth elsewhere. While at it, move u64_swap to its only
> user, evsel.h.

please put the 'u64_swap move' into separated patch
plus one nit below 

thanks,
jirka

> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  .../lockdep/uinclude => include}/linux/types.h     | 29 +++++++++++++++++-----
>  tools/perf/MANIFEST                                |  1 +

SNIP

> diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg
> index 238aa3927c71..3017d82a700f 100755
> --- a/tools/perf/tests/perf-targz-src-pkg
> +++ b/tools/perf/tests/perf-targz-src-pkg
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>  # Test one of the main kernel Makefile targets to generate a perf sources tarball
>  # suitable for build outside the full kernel sources.
>  #
> @@ -7,15 +7,17 @@
>  # like when we made some files that were in tools/perf/ available to other tools/
>  # codebases by moving it to tools/include/, etc.
>  
> +set -x
> +
>  PERF=$1
>  cd ${PERF}/../..
>  make perf-targz-src-pkg > /dev/null
>  TARBALL=$(ls -rt perf-*.tar.gz)
>  TMP_DEST=$(mktemp -d)
>  tar xf ${TARBALL} -C $TMP_DEST
> -rm -f ${TARBALL}
> +# rm -f ${TARBALL}
>  cd - > /dev/null
> -make -C $TMP_DEST/perf*/tools/perf > /dev/null 2>&1
> +make -C $TMP_DEST/perf*/tools/perf > w.log 2>&1
>  RC=$?
> -rm -rf ${TMP_DEST}
> +# rm -rf ${TMP_DEST}
>  exit $RC

leftover from another change ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/