linux-kernel - Re: [PATCH 2/3] ARM : kdump : add arch_crash_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140414113718.GD3530@arm.com>
Date:	Mon, 14 Apr 2014 12:37:18 +0100
From:	Will Deacon <will.deacon@....com>
To:	Liu Hua <sdu.liu@...wei.com>
Cc:	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"horms@...ge.net.au" <horms@...ge.net.au>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
	Stephen Warren <swarren@...dia.com>,
	Vijaya Kumar K <vijay.kilari@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo

On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote:
> For vmcore generated by LPAE enabled kernel, user space
> utility such as crash needs additional infomation to
> parse.
> 
> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled
> i386 linux does.

Looks sensible to me:

  Reviewed-by: Will Deacon <will.deacon@....com>

Will

> Signed-off-by: Liu Hua <sdu.liu@...wei.com>
> To: Russell King <linux@....linux.org.uk>
> Cc: Stephen Warren <swarren@...dia.com> 
> Cc: Will Deacon <will.deacon@....com>
> Cc: Vijaya Kumar K <vijay.kilari@...il.com>
> Cc: <linux-arm-kernel@...ts.infradead.org>
> Cc: <linux-kernel@...r.kernel.org>
> Cc: <kexec@...ts.infradead.org>
> ---
>  arch/arm/kernel/machine_kexec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f0d180d..8cf0996 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image)
>  
>  	soft_restart(reboot_entry_phys);
>  }
> +
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_ARM_LPAE
> +	VMCOREINFO_CONFIG(ARM_LPAE);
> +#endif
> +}
> -- 
> 1.9.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/