| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1397482917.11914.128.camel@smile.fi.intel.com> Date: Mon, 14 Apr 2014 16:41:57 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Hongbo Zhang <hongbo.zhang@...escale.com> Cc: vkoul@...radead.org, dan.j.williams@...el.com, dmaengine@...r.kernel.org, scottwood@...escale.com, leo.li@...escale.com, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 6/8] DMA: Freescale: change descriptor release process for supporting async_tx On Fri, 2014-04-11 at 16:33 +0800, Hongbo Zhang wrote: > >>> + * hardware channel, subsequent descriptors are either in > >>> + * process or have not been submitted > >> Dot at the eol. Check in all comments. > > > > Even though I saw there are other comments without the dots, I think > > it is better to have it. > > Thanks, all. > > > Hmm... think it again, it it really necessary to have it? > Even I have it in my patch, there are already so many comments exists > without it. For my opinion is better to keep style in your patches. Better if it commonly used style in the driver. But comment against comments is really minor thing. -- Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists