linux-kernel - Re: [PATCH] ARM: VFP: Fix emulation of multiply accumulate instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANd1uZmHi2PB0FLZ8zox_X2kbaMz_td0xqo7PkC3bP1jQNMfSw@mail.gmail.com>
Date:	Mon, 14 Apr 2014 16:26:49 +0100
From:	Jay Foad <jay.foad@...il.com>
To:	Dave Martin <Dave.Martin@....com>
Cc:	linux@....linux.org.uk, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: VFP: Fix emulation of multiply accumulate instructions

On 8 April 2014 14:13, Dave Martin <Dave.Martin@....com> wrote:
> On Wed, Mar 26, 2014 at 04:49:09PM +0000, Jay Foad wrote:
>> The emulation for single and double precision multiply accumulate
>> instructions correctly normalised any denormal values in the operand
>> registers, but failed to normalise the destination (accumulator)
>> register.
>>
>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=70501
>>
>> Signed-off-by: Jay Foad <jay.foad@...il.com>
>
> Reviewed-by: Dave Martin <Dave.Martin@....com>
>
> This appears to be clean and straightforward, so if nobody else has
> commented on this by the time -rc1 comes out, I suggest you rebase it
> and send it to the patch system.  (See
> http://www.arm.linux.org.uk/developer/patches/info.php for details
> -- make sure you read it carefully.)

Done.

> Has this issue been hitting real-world users of the kernel, or is
> this fixing a latent bug?

Real world: it was causing failures in the test suite for an APL
interpreter running on the Raspberry Pi.

Thanks,
Jay.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/