linux-kernel - Re: [PATCH 1/1] fanotify: create FAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 17:49:11 +0200
From:	Jan Kara <jack@...e.cz>
To:	xypron.glpk@....de
Cc:	viro@...iv.linux.org.uk, jack@...e.cz, eparis@...hat.com,
	mtk.manpages@...il.com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] fanotify: create FAN_ACCESS event for readdir

On Sun 13-04-14 18:10:30, xypron.glpk@....de wrote:
> From: Heinrich Schuchardt <xypron.glpk@....de>
> 
> Before the patch,
> read creates FAN_ACCESS_PERM and FAN_ACCESS events,
> readdir creates only FAN_ACCESS_PERM events.
> 
> This is inconsistent.
> 
> After the patch,
> readdir creates FAN_ACCESS_PERM and FAN_ACCESS events.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
  Makes sense. You can add:
Reviewed-by: Jan Kara <jack@...e.cz>

							Honza

> ---
>  fs/readdir.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 5b53d99..33fd922 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -13,6 +13,7 @@
>  #include <linux/stat.h>
>  #include <linux/file.h>
>  #include <linux/fs.h>
> +#include <linux/fsnotify.h>
>  #include <linux/dirent.h>
>  #include <linux/security.h>
>  #include <linux/syscalls.h>
> @@ -40,6 +41,7 @@ int iterate_dir(struct file *file, struct dir_context *ctx)
>  		ctx->pos = file->f_pos;
>  		res = file->f_op->iterate(file, ctx);
>  		file->f_pos = ctx->pos;
> +		fsnotify_access(file);
>  		file_accessed(file);
>  	}
>  	mutex_unlock(&inode->i_mutex);
> -- 
> 1.7.10.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/