linux-kernel - Re: [PATCH 2/2] x86, MCE: Cleanup macro __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534C0A74.6030305@zytor.com>
Date:	Mon, 14 Apr 2014 09:19:00 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Chen, Gong" <gong.chen@...ux.intel.com>, tony.luck@...el.com
CC:	tglx@...utronix.de, mingo@...nel.org, linux-kernel@...r.kernel.org,
	linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH 2/2] x86, MCE: Cleanup macro __get_cpu_var

On 04/14/2014 01:39 AM, Chen, Gong wrote:
> @@ -619,7 +619,7 @@ void machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
>  			continue;
>  
>  		v = &get_cpu_var(mce_polled_error);
> -		set_bit(0, v);
> +		*v = 1;
>  		put_cpu_var(mce_polled_error);
>  		/*
>  		 * Uncorrected or signalled events are handled by the exception

The amazing thing is that you managed to miss the one place where you
could actively elide a pointer.

The above should simply be:

	this_cpu_write(mce_polled_error, 1);

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/