linux-kernel - Re: [PATCH] arm64:init: Move of_clk_init to time_init

Open Source and information security mailing list archives

Message-ID: <20140414164635.GD12916@arm.com>
Date:	Mon, 14 Apr 2014 17:46:35 +0100
From:	Will Deacon <will.deacon@....com>
To:	Chanho Min <chanho.min@....com>
Cc:	Catalin Marinas <Catalin.Marinas@....com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64:init: Move of_clk_init to time_init

On Mon, Apr 14, 2014 at 08:38:53AM +0100, Chanho Min wrote:
> Clock providers should be initialized before clocksource_of_init.
> If not, Clock source initialization can be fail to get the clock.
> 
> Signed-off-by: Chanho Min <chanho.min@....com>

Acked-by: Will Deacon <will.deacon@....com>

Will

> ---
>  arch/arm64/kernel/setup.c |    1 -
>  arch/arm64/kernel/time.c  |    3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 720853f..93e7df89 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -393,7 +393,6 @@ void __init setup_arch(char **cmdline_p)
>  
>  static int __init arm64_device_init(void)
>  {
> -	of_clk_init(NULL);
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>  	return 0;
>  }
> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
> index 29c39d5..8799242 100644
> --- a/arch/arm64/kernel/time.c
> +++ b/arch/arm64/kernel/time.c
> @@ -33,6 +33,7 @@
>  #include <linux/irq.h>
>  #include <linux/delay.h>
>  #include <linux/clocksource.h>
> +#include <linux/clk-provider.h>
>  
>  #include <clocksource/arm_arch_timer.h>
>  
> @@ -64,7 +65,7 @@ EXPORT_SYMBOL(profile_pc);
>  void __init time_init(void)
>  {
>  	u32 arch_timer_rate;
> -
> +	of_clk_init(NULL);
>  	clocksource_of_init();
>  
>  	arch_timer_rate = arch_timer_get_rate();
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives