linux-kernel - Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 10:08:02 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>, x86@...nel.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	jasowang@...hat.com, tglx@...utronix.de, JBeulich@...e.com
Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> +	new_val = inb(PIC_MASTER_IMR);
> +	if (probe_val != new_val) {

Nitpick: Linux coding style should have this as:

	if (new_val != probe_val)

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/