linux-kernel - Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140414173100.GI4496@linux.vnet.ibm.com>
Date:	Mon, 14 Apr 2014 10:31:00 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <pranith@...ech.edu>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

On Mon, Apr 14, 2014 at 12:27:47PM -0400, Pranith Kumar wrote:
> On Mon, Apr 14, 2014 at 12:19 PM, Pranith Kumar <pranith@...ech.edu> wrote:
> > Hi Paul,
> >
> > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> > <paulmck@...ux.vnet.ibm.com> wrote:
> >> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> >>> remove duplicate definition of extern resched_cpu
> >>>
> >>> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
> >>
> >> Hello, Pranith,
> >>
> >> When I apply this patch I get the following:
> >>
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: In function ‘rcu_implicit_dynticks_qs’:
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: error: implicit declaration of function ‘resched_cpu’ [-Werror=implicit-function-declaration]
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: At top level:
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:1009:13: warning: conflicting types for ‘resched_cpu’ [enabled by default]
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: note: previous implicit declaration of ‘resched_cpu’ was here
> >>
> >> This failed in under number of different Kconfig setups, the .config file
> >> for one of them is attached.
> >>
> >> So this declaration really is needed.  Just out of curiosity, what led
> >> you to believe that it could be removed?
> >>
> 
> Your attached config has the following:
> 
> Linux/x86 3.14.0-rc3 Kernel Configuration
> 
> The patch is against 3.15.0-rc1 (the latest at this time). May be that
> is the reason?

Nope, it was just me messing up when hand-applying the patch.  The reason
the patch wouldn't apply is that I am working against the -rcu tree at
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git,
branch rcu/dev.  Once I applied it correctly, removing the second of
the two declarations rather than the first one, it worked fine.

So please accept my apologies for my confusion.  I have queued your
patch for 3.16, thank you!

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/