linux-kernel - Re: [PATCH] seccomp: fix memory leak on filter attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 20:23:58 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Kees Cook <keescook@...omium.org>
CC:	linux-kernel@...r.kernel.org,
	Masami Ichikawa <masami256@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Josh Triplett <josh@...htriplett.org>,
	Rashika Kheria <rashika.kheria@...il.com>,
	James Morris <james.l.morris@...cle.com>, davem@...emloft.net,
	eparis@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] seccomp: fix memory leak on filter attach

On 04/14/2014 07:11 PM, Kees Cook wrote:
> This sets the correct error code when final filter memory is unavailable,
> and frees the raw filter no matter what.
>
> unreferenced object 0xffff8800d6ea4000 (size 512):
>    comm "sshd", pid 278, jiffies 4294898315 (age 46.653s)
>    hex dump (first 32 bytes):
>      21 00 00 00 04 00 00 00 15 00 01 00 3e 00 00 c0  !...........>...
>      06 00 00 00 00 00 00 00 21 00 00 00 00 00 00 00  ........!.......
>    backtrace:
>      [<ffffffff8151414e>] kmemleak_alloc+0x4e/0xb0
>      [<ffffffff811a3a40>] __kmalloc+0x280/0x320
>      [<ffffffff8110842e>] prctl_set_seccomp+0x11e/0x3b0
>      [<ffffffff8107bb6b>] SyS_prctl+0x3bb/0x4a0
>      [<ffffffff8152ef2d>] system_call_fastpath+0x1a/0x1f
>      [<ffffffffffffffff>] 0xffffffffffffffff
>
> Reported-by: Masami Ichikawa <masami256@...il.com>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Cc: stable@...r.kernel.org

Acked-by: Daniel Borkmann <dborkman@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/