linux-kernel - Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 14:58:51 -0400
From:	Joseph Salisbury <joseph.salisbury@...onical.com>
To:	linux-kernel@...r.kernel.org, benh@...nel.crashing.org,
	paulus@...ba.org
CC:	linuxppc-dev@...ts.ozlabs.org, stable@...r.kernel.org,
	anton@...ba.org
Subject: Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from
 512.

On 04/14/2014 11:30 AM, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1306677
>
> While booting the PPC64EL kernel, the command line gets truncated to 512 characters. This is due to a hard limit of 512 defined for COMMAND_LINE_SIZE.  It would be beneficial to have a command line longer than 512 characters, as iscsi targets and cloud-init parameters are passed through the kernel command line.
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@...onical.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> (supporter:LINUX FOR POWERPC...)
> Cc: Paul Mackerras <paulus@...ba.org> (supporter:LINUX FOR POWERPC...)
> Cc: linuxppc-dev@...ts.ozlabs.org (open list:LINUX FOR POWERPC...)
> Cc: linux-kernel@...r.kernel.org (open list)
> Cc: stable@...r.kernel.org
>
> ---
>  arch/powerpc/boot/ops.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/boot/ops.h b/arch/powerpc/boot/ops.h
> index b3218ce..5a01fb1 100644
> --- a/arch/powerpc/boot/ops.h
> +++ b/arch/powerpc/boot/ops.h
> @@ -15,7 +15,7 @@
>  #include "types.h"
>  #include "string.h"
>  
> -#define	COMMAND_LINE_SIZE	512
> +#define	COMMAND_LINE_SIZE	2048	
>  #define	MAX_PATH_LEN		256
>  #define	MAX_PROP_LEN		256 /* What should this be? */
>  

After further review, it appears ppc does not actually use the define in
the ppc headers but uses the common generic
default(include/uapi/asm-generic/setup.h).  COMMAND_LINE_SIZE should
probably become a kernel config option.  Do folks agree that is the
correct thing to do?  If so, I can re-work the patch.

Thanks,

Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/