linux-kernel - Re: [PATCH v2 1/2] ASoC: fsl_sai: Add clock controls for SAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140414204331.GE25182@sirena.org.uk>
Date:	Mon, 14 Apr 2014 21:43:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <Guangyu.Chen@...escale.com>
Cc:	shawn.guo@...aro.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
	timur@...i.org, Li.Xiubo@...escale.com, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, rob@...dley.net, galak@...eaurora.org,
	ijc+devicetree@...lion.org.uk, mark.rutland@....com,
	pawel.moll@....com, robh+dt@...nel.org
Subject: Re: [PATCH v2 1/2] ASoC: fsl_sai: Add clock controls for SAI

On Wed, Apr 02, 2014 at 06:10:19PM +0800, Nicolin Chen wrote:

> -- clock-names : Must include the "sai" entry.
> +- clock-names : Must include the "bus" for register access and "mclk1" "mclk2"
> +  "mclk3" for bit clock and frame clock providing.

This breaks compatibilty with old DTs - it just removes the "sai" name.
It's OK to deprecate the "sai" clock name but you need to keep support
for DTs that only specify that, there's no code for that left in the
driver.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)