linux-kernel - RE: [PATCH] drm/radeon: fix VCE fence command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A3397C8B8B789E45844E7EC5DEAD89D03ECB19EF@satlexdag05.amd.com>
Date:	Mon, 14 Apr 2014 22:13:08 +0000
From:	"Deucher, Alexander" <Alexander.Deucher@....com>
To:	Christoph Jaeger <christophjaeger@...ux.com>,
	"Koenig, Christian" <Christian.Koenig@....com>,
	"airlied@...ux.ie" <airlied@...ux.ie>
CC:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/radeon: fix VCE fence command

> -----Original Message-----
> From: Christoph Jaeger [mailto:christophjaeger@...ux.com]
> Sent: Monday, April 14, 2014 6:10 PM
> To: Deucher, Alexander; Koenig, Christian; airlied@...ux.ie
> Cc: dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Christoph
> Jaeger
> Subject: [PATCH] drm/radeon: fix VCE fence command
> 
> Due to a type mismatch that causes an implicit type conversion, the
> upper 32 bits of the GPU address have been zeroed out when adding to the
> command buffer.
> 
> Picked up by Coverity - CID 1198624.
> 
> Signed-off-by: Christoph Jaeger <christophjaeger@...ux.com>

Good catch!

Reviewed-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
> b/drivers/gpu/drm/radeon/radeon_vce.c
> index 76e9904..ced53dd 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
> *rdev,
>  			   struct radeon_fence *fence)
>  {
>  	struct radeon_ring *ring = &rdev->ring[fence->ring];
> -	uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> +	uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> 
>  	radeon_ring_write(ring, VCE_CMD_FENCE);
>  	radeon_ring_write(ring, addr);
> --
> 1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/