linux-kernel - Re: [patch 2/4] mm: Dont forget to set softdirty on file mapped fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140414152758.a9a80782dbb94c74a27f683a@linux-foundation.org>
Date:	Mon, 14 Apr 2014 15:27:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, hughd@...gle.com,
	xemul@...allels.com
Subject: Re: [patch 2/4] mm: Dont forget to set softdirty on file mapped
 fault

On Mon, 24 Mar 2014 16:28:40 +0400 Cyrill Gorcunov <gorcunov@...nvz.org> wrote:

> Otherwise we may not notice that pte was softdirty.
> 
> --- linux-2.6.git.orig/mm/memory.c
> +++ linux-2.6.git/mm/memory.c
> @@ -3422,7 +3422,7 @@ static int __do_fault(struct mm_struct *
>  		if (flags & FAULT_FLAG_WRITE)
>  			entry = maybe_mkwrite(pte_mkdirty(entry), vma);
>  		else if (pte_file(orig_pte) && pte_file_soft_dirty(orig_pte))
> -			pte_mksoft_dirty(entry);
> +			entry = pte_mksoft_dirty(entry);
>  		if (anon) {
>  			inc_mm_counter_fast(mm, MM_ANONPAGES);
>  			page_add_new_anon_rmap(page, vma, address);

This will need to be redone for current kernels, please.  New patch, new
title, new changelog, retest.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/