[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140414230855.GC1877@localhost.localdomain>
Date: Tue, 15 Apr 2014 01:08:57 +0200
From: Frederic Weisbecker <fweisbec@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: tglx@...utronix.de, linaro-kernel@...ts.linaro.org,
linux-kernel@...r.kernel.org, Arvind.Chauhan@....com,
linaro-networking@...aro.org
Subject: Re: [PATCH 24/38] tick-sched: don't check tick_nohz_full_cpu() in
__tick_nohz_task_switch()
On Mon, Apr 14, 2014 at 09:53:46PM +0530, Viresh Kumar wrote:
> __tick_nohz_task_switch() calls tick_nohz_full_kick(), which is already checking
> tick_nohz_full_cpu() and so we don't need to repeat the same check here.
>
> Remove it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
Ack.
> ---
> kernel/time/tick-sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 256f4a3..5a99859 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -261,13 +261,9 @@ void __tick_nohz_task_switch(struct task_struct *tsk)
>
> local_irq_save(flags);
>
> - if (!tick_nohz_full_cpu(smp_processor_id()))
> - goto out;
> -
> if (tick_nohz_tick_stopped() && !can_stop_full_tick())
> tick_nohz_full_kick();
>
> -out:
> local_irq_restore(flags);
> }
>
> --
> 1.7.12.rc2.18.g61b472e
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists