linux-kernel - Re: [PATCH 00/20] Introduce new cpufreq helper macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 11:31:49 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"David S. Miller" <davem@...emloft.net>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	Dirk Brandewie <dirk.j.brandewie@...el.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	linux-doc@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 00/20] Introduce new cpufreq helper macros

On 15 April 2014 02:37, Stratos Karafotis <stratosk@...aphore.gr> wrote:
> This patch set introduces two freq_table helper macros which
> can be used for iteration over cpufreq_frequency_table and
> makes the necessary changes to cpufreq core and drivers that
> use such an iteration procedure.
>
> The motivation was a usage of common procedure to iterate over
> cpufreq_frequency_table across all drivers and cpufreq core.
>
> This was tested on a x86_64 platform.
> Patches 4-17 compiled successfully but unfortunately I was not
> able to compile test patches 18-20.

Mostly okay, just some Nitpicks..

Please rearrange your patches this way:
- First patch just adds the wrappers
- Second one makes changes to drivers/cpufreq/, i.e. include all core
and drivers
  changes into a single patch here as the logs are exactly same.
- Then framework by framework, as we may need Acks/Reviews by them
  separately..

So, probably just 5-7 would do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/