linux-kernel - Re: [PATCH] video: bf54x-lq043fb: fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMk6uBmxzJrbaQoiGcW2N5DtAqC16YErdd3tV5B4RP+nyNFdmA@mail.gmail.com>
Date:	Tue, 15 Apr 2014 14:35:06 +0800
From:	Steven Miao <realmz6@...il.com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	Steven Miao <realmz6@...nel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	bfin <adi-buildroot-devel@...ts.sourceforge.net>,
	"open list:CAN NETWORK DRIVERS <linux-can@...r.kernel.org>, open
	list:NETWORKING DRIVERS <netdev@...r.kernel.org>, open list" 
	<linux-kernel@...r.kernel.org>, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error

Hi Tomi,

On Mon, Apr 14, 2014 at 8:44 PM, Tomi Valkeinen <tomi.valkeinen@...com> wrote:
> On 12/04/14 04:30, Steven Miao wrote:
>> From: Steven Miao <realmz6@...il.com>
>>
>> should include linux/gpio.h
>>
>> Signed-off-by: Steven Miao <realmz6@...il.com>
>> ---
>>  drivers/video/bf54x-lq043fb.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
>> index 42b8f9d..d2b54f1 100644
>> --- a/drivers/video/bf54x-lq043fb.c
>> +++ b/drivers/video/bf54x-lq043fb.c
>> @@ -49,6 +49,7 @@
>>  #include <linux/spinlock.h>
>>  #include <linux/dma-mapping.h>
>>  #include <linux/platform_device.h>
>> +#include <linux/gpio.h>
>
> The driver includes <asm/gpio.h>. I think that should be removed, and
> <linux/gpio.h> should be used.
Yes, it should be removed.
>
> Can you also remove the asm/gpio.h in your patch, and see if it compiles
> fine?
I have tested it, it's fine. I'll resend the patch.
>
>  Tomi
>
>
-steven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/