linux-kernel - Re: [PATCH] drm/nouveau/clk: fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1876072135.7241792.1397545235729.JavaMail.zimbra@redhat.com>
Date:	Tue, 15 Apr 2014 03:00:35 -0400 (EDT)
From:	Ben Skeggs <bskeggs@...hat.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau/clk: fix possible NULL pointer dereference

----- Original Message -----
> From: "Daeseok Youn" <daeseok.youn@...il.com>
> To: airlied@...ux.ie
> Cc: bskeggs@...hat.com, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
> Sent: Tuesday, 15 April, 2014 11:56:49 AM
> Subject: [PATCH] drm/nouveau/clk: fix possible NULL pointer dereference
> 
> 
> It need to be checking NULL before dereferencing.
There's no dereference here.  It's an address calculation only.

> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  drivers/gpu/drm/nouveau/core/subdev/clock/base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/core/subdev/clock/base.c
> b/drivers/gpu/drm/nouveau/core/subdev/clock/base.c
> index dd62bae..a586d030 100644
> --- a/drivers/gpu/drm/nouveau/core/subdev/clock/base.c
> +++ b/drivers/gpu/drm/nouveau/core/subdev/clock/base.c
> @@ -290,9 +290,9 @@ nouveau_pstate_new(struct nouveau_clock *clk, int idx)
>  		return 0;
>  
>  	pstate = kzalloc(sizeof(*pstate), GFP_KERNEL);
> -	cstate = &pstate->base;
>  	if (!pstate)
>  		return -ENOMEM;
> +	cstate = &pstate->base;
>  
>  	INIT_LIST_HEAD(&pstate->list);
>  
> --
> 1.7.4.4
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/