linux-kernel - Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <008401cf5843$d4ce80b0$7e6b8210$%han@samsung.com>
Date:	Tue, 15 Apr 2014 09:44:17 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Pascal COMBES' <pascom@...nge.fr>,
	'Paul Bolle' <pebolle@...cali.nl>
Cc:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	'Peter P Waskiewicz Jr' <peter.p.waskiewicz.jr@...el.com>,
	'Jarod Wilson' <jarod@...sonet.com>,
	'Valentina Manea' <valentina.manea.m@...il.com>,
	linux-kernel@...r.kernel.org,
	'Naren Sankar' <nsankar@...adcom.com>,
	'Monam Agarwal' <monamagarwal123@...il.com>,
	'Scott Davilla' <davilla@....com>,
	'Amarjargal Gundjalam' <amarjargal16@...il.com>,
	'Dan Carpenter' <dan.carpenter@...cle.com>,
	'Robert Foss' <dev@...ertfoss.se>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in
 drivers/staging/crystalhd/crystalhd_lnx.c

On Tuesday, April 15, 2014 1:38 AM, Pascal COMBES wrote:
> 
> Le 13/04/2014 23:36, Paul Bolle a écrit :
> > On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote:
> >> From: Pascal COMBES <pascom@...nge.fr>
> >>
> >> Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c:
> >> No space needed before a cast.
> >>
> >> Signed-off-by: Pascal COMBES <pascom@...nge.fr>
> >> ---
> >> diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
> >> index fd7f08a..15e8f02 100644
> >> --- a/drivers/staging/crystalhd/crystalhd_lnx.c
> >> +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
> >> @@ -28,7 +28,7 @@ static struct crystalhd_adp *g_adp_info;
> >>
> >>  static irqreturn_t chd_dec_isr(int irq, void *arg)
> >>  {
> >> -	struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
> >> +	struct crystalhd_adp *adp = (struct crystalhd_adp *)arg;
> >
> > Shouldn't this cast just be dropped instead?
> 
> I think as you and was wondering why it was there but I didn't dare
> removing it. I considered it was not really coding style.
> But after second thought, I will remove it when I resend tomrorrow.

Please, remove unnecessary void cast as below.

 -	struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
 +	struct crystalhd_adp *adp = arg;

This is because the conversion from void pointer to any other
pointer type is guaranteed by the C programming language.
So, void cast is unnecessary.

Best regards,
Jingoo Han

> 	Regards,
> Pascal COMBES.
> >
> >>  	int rc = 0;
> >>  	if (adp)
> >>  		rc = crystalhd_cmd_interrupt(&adp->cmds);
> >>
> >
> >
> > Paul Bolle
> >
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/