linux-kernel - Re: [PATCH] [TRIVIAL] Kconfig: Remove useless "default N" lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 10:08:34 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jiri Kosina <trivial@...nel.org>
Cc:	Martin Walch <walch.martin@....de>,
	Richard Weinberger <richard@....at>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Kconfig: Remove useless "default N" lines

Jiri,

On Tue, 2014-02-11 at 13:38 +0100, Paul Bolle wrote:
> A number of Kconfig entries default to (uppercase) "N". It was clearly
> intended to use "default n". But since (lowercase) "n" is the default
> anyway, these lines might as well be removed.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
>[...]
> 
>  arch/arc/Kconfig                          | 1 -
>  arch/cris/arch-v32/drivers/Kconfig        | 2 --
>  drivers/misc/mic/Kconfig                  | 2 --
>  drivers/staging/android/Kconfig           | 2 --
>  drivers/staging/bcm/Kconfig               | 1 -
>  drivers/staging/frontier/Kconfig          | 1 -
>  drivers/staging/media/go7007/Kconfig      | 3 ---
>  drivers/staging/rtl8187se/Kconfig         | 1 -
>  drivers/staging/rtl8188eu/Kconfig         | 1 -
>  drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
>  drivers/staging/rtl8192u/Kconfig          | 1 -
>  drivers/staging/rtl8712/Kconfig           | 2 --
>  drivers/staging/rtl8821ae/Kconfig         | 1 -

This file wasn't touched by our commit c7dcec7dd463 ("Kconfig: Remove
useless "default N" lines"). Any idea why?

>  drivers/staging/usbip/Kconfig             | 4 ----
>  drivers/usb/core/Kconfig                  | 1 -
>  drivers/usb/host/Kconfig                  | 3 ---
>  16 files changed, 27 deletions(-)
> 
> [...]
>
> diff --git a/drivers/staging/rtl8821ae/Kconfig b/drivers/staging/rtl8821ae/Kconfig
> index 2aa5dac..4679fd8 100644
> --- a/drivers/staging/rtl8821ae/Kconfig
> +++ b/drivers/staging/rtl8821ae/Kconfig
> @@ -6,6 +6,5 @@ config R8821AE
>  	select WEXT_PRIV
>  	select EEPROM_93CX6
>  	select CRYPTO
> -	default N
>  	---help---
>  	  If built as a module, it will be called r8821ae.ko.

So this "default N" statement is still present in v3.15-rc1.

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/