linux-kernel - Re: [PATCH] cif: fix dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140415081612.GV18016@ZenIV.linux.org.uk>
Date:	Tue, 15 Apr 2014 09:16:12 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	sfrench@...ba.org, linux-cifs@...r.kernel.org,
	geert@...ux-m68k.org, samba-technical@...ts.samba.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cif: fix dead code

On Tue, Apr 15, 2014 at 10:06:50AM +0200, Michael Opdenacker wrote:
> This issue was found by Coverity (CID 1202536)
> 
> This proposes a fix for a statement that creates dead code.
> The "rc < 0" statement is within code that is run
> with "rc > 0".
> 
> It seems like "err < 0" was meant to be used here.
> This way, the error code is returned by the function.

Acked-by: Al Viro <viro@...iv.linux.org.uk>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/