linux-kernel - RE: [PATCH] qlcnic: Fix MSI-X initialization code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A46F910CF@avmb2.qlogic.org>
Date:	Tue, 15 Apr 2014 12:06:58 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Alexander Gordeev <agordeev@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	linux-pci <linux-pci@...r.kernel.org>
Subject: RE: [PATCH] qlcnic: Fix MSI-X initialization code

> -----Original Message-----
> From: Alexander Gordeev [mailto:agordeev@...hat.com]
> Sent: Tuesday, April 15, 2014 3:07 PM
> To: linux-kernel
> Cc: Alexander Gordeev; Shahed Shaikh; Dept-HSG Linux NIC Dev; netdev;
> linux-pci
> Subject: [PATCH] qlcnic: Fix MSI-X initialization code
> 
> Function qlcnic_setup_tss_rss_intr() might enter endless loop in case
> pci_enable_msix() contiguously returns a positive number of MSI-Xs that
> could have been allocated.
> Besides, the function contains 'err = -EIO;' assignment that never could be
> reached. This update fixes the aforementioned issues.
> 
> Cc: Shahed Shaikh <shahed.shaikh@...gic.com>
> Cc: Dept-HSGLinuxNICDev@...gic.com
> Cc: netdev@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> 
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>

Acked-by: Shahed Shaikh <shahed.shaikh@...gic.com>

Thanks,
Shahed
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |   28 ++++++++++++-------
> --
>  1 files changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 309d056..2e615d5 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -670,7 +670,7 @@ int qlcnic_setup_tss_rss_intr(struct qlcnic_adapter
> *adapter)
>  	else
>  		num_msix += adapter->drv_tx_rings;
> 
> -	if (adapter->drv_rss_rings  > 0)
> +	if (adapter->drv_rss_rings > 0)
>  		num_msix += adapter->drv_rss_rings;
>  	else
>  		num_msix += adapter->drv_sds_rings;
> @@ -686,19 +686,15 @@ int qlcnic_setup_tss_rss_intr(struct qlcnic_adapter
> *adapter)
>  			return -ENOMEM;
>  	}
> 
> -restore:
>  	for (vector = 0; vector < num_msix; vector++)
>  		adapter->msix_entries[vector].entry = vector;
> 
> +restore:
>  	err = pci_enable_msix(pdev, adapter->msix_entries, num_msix);
> -	if (err == 0) {
> -		adapter->ahw->num_msix = num_msix;
> -		if (adapter->drv_tss_rings > 0)
> -			adapter->drv_tx_rings = adapter->drv_tss_rings;
> +	if (err > 0) {
> +		if (!adapter->drv_tss_rings && !adapter->drv_rss_rings)
> +			return -ENOSPC;
> 
> -		if (adapter->drv_rss_rings > 0)
> -			adapter->drv_sds_rings = adapter->drv_rss_rings;
> -	} else {
>  		netdev_info(adapter->netdev,
>  			    "Unable to allocate %d MSI-X vectors, Available
> vectors %d\n",
>  			    num_msix, err);
> @@ -716,12 +712,20 @@ restore:
>  			    "Restoring %d Tx, %d SDS rings for total %d
> vectors.\n",
>  			    adapter->drv_tx_rings, adapter->drv_sds_rings,
>  			    num_msix);
> -		goto restore;
> 
> -		err = -EIO;
> +		goto restore;
> +	} else if (err < 0) {
> +		return err;
>  	}
> 
> -	return err;
> +	adapter->ahw->num_msix = num_msix;
> +	if (adapter->drv_tss_rings > 0)
> +		adapter->drv_tx_rings = adapter->drv_tss_rings;
> +
> +	if (adapter->drv_rss_rings > 0)
> +		adapter->drv_sds_rings = adapter->drv_rss_rings;
> +
> +	return 0;
>  }
> 
>  int qlcnic_enable_msix(struct qlcnic_adapter *adapter, u32 num_msix)
> --
> 1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/