linux-kernel - Re: [PATCH 1/5] ASoC: omap: rx51: Use devm_snd_soc_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140415122044.GZ12304@sirena.org.uk>
Date:	Tue, 15 Apr 2014 13:20:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	Sebastian Reichel <sre@...g0.de>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Tony Lindgren <tony@...mide.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, alsa-devel@...a-project.org,
	Pali Rohár <pali.rohar@...il.com>
Subject: Re: [PATCH 1/5] ASoC: omap: rx51: Use devm_snd_soc_register_card

On Sat, Apr 05, 2014 at 11:35:49PM +0200, Sebastian Reichel wrote:
> From: Pali Rohár <pali.rohar@...il.com>
> 
> This patch converts the rx51 ASoC module to use
> devm_snd_soc_register_card. It also adds module alias
> to support driver autoloading.

This doesn't apply against current code and since it does multiple
things it should be multiple patches.

> +static int rx51_soc_remove(struct platform_device *pdev)
>  {
> +	struct snd_soc_card *card = platform_get_drvdata(pdev);
> +
>  	snd_soc_jack_free_gpios(&rx51_av_jack, ARRAY_SIZE(rx51_av_jack_gpios),
>  				rx51_av_jack_gpios);
>  
> -	platform_device_unregister(rx51_snd_device);
> +	card->dev = NULL;
> +

Why is this assignment being done?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)