linux-kernel - Re: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534D27AB.7070109@linaro.org>
Date:	Tue, 15 Apr 2014 14:35:55 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>, tglx@...utronix.de,
	shawn.guo@...aro.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

On 04/15/2014 12:48 PM, Xiubo Li wrote:
> The pit_read_sched_clock mean to getting the current counter value,
> and the vf pit timer is a down count timer, this should return
> the counter value or the cycles elapsed.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---
>   drivers/clocksource/vf_pit_timer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/vf_pit_timer.c b/drivers/clocksource/vf_pit_timer.c
> index 02821b0..a918bc4 100644
> --- a/drivers/clocksource/vf_pit_timer.c
> +++ b/drivers/clocksource/vf_pit_timer.c
> @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
>
>   static u64 pit_read_sched_clock(void)
>   {
> -	return __raw_readl(clksrc_base + PITCVAL);
> +	return ~__raw_readl(clksrc_base + PITCVAL);
>   }
>
>   static int __init pit_clocksource_init(unsigned long rate)
>

Hi Xiubo,

thanks for the patch but this has already been fixed [1] and is 
available in the timers/urgent branch.

Thanks

   -- Daniel

[1] 
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=224aa3ed45c8735ae02bb2ecca002409fa6aa772
-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/