linux-kernel - Re: [PATCH] gpio: ich: set regs and reglen for i3100 and ich6 chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 10:43:52 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Vincent Donnefort <vdonnefort@...il.com>
Cc:	linux-kernel@...r.kernel.org, ptyser@...-inc.com,
	linus.walleij@...aro.org, gnurou@...il.com,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH] gpio: ich: set regs and reglen for i3100 and ich6
 chipset

On Tue, 2014-04-15 at 14:21 +0200, Vincent Donnefort wrote:
> From: Vincent Donnefort <vdonnefort@...il.com>
> 
> This patch fixes kernel NULL pointer BUG introduced by the following commit:
> b667cf488aa9476b0ab64acd91f2a96f188cfd21
> gpio: ich: Add support for multiple register addresses.
> 
> Signed-off-by: Vincent Donnefort <vdonnefort@...il.com>

Things seem much happier now!  Thank you sir!

Tested-by: Eric Paris <eparis@...hat.com>

> 
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index e73c675..7030422 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -305,6 +305,8 @@ static struct ichx_desc ich6_desc = {
>  
>  	.ngpio = 50,
>  	.have_blink = true,
> +	.regs = ichx_regs,
> +	.reglen = ichx_reglen,
>  };
>  
>  /* Intel 3100 */
> @@ -324,6 +326,8 @@ static struct ichx_desc i3100_desc = {
>  	.uses_gpe0 = true,
>  
>  	.ngpio = 50,
> +	.regs = ichx_regs,
> +	.reglen = ichx_reglen,
>  };
>  
>  /* ICH7 and ICH8-based */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/