lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Apr 2014 10:33:26 +0800 From: Nicolin Chen <Guangyu.Chen@...escale.com> To: Mark Brown <broonie@...nel.org> CC: <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>, <alsa-devel@...a-project.org>, <timur@...i.org>, <Li.Xiubo@...escale.com> Subject: Re: [PATCH] ASoC: fsl_sai: Fix incorrect condition check in trigger() On Mon, Apr 14, 2014 at 09:31:26PM +0100, Mark Brown wrote: > On Fri, Apr 11, 2014 at 10:10:00PM +0800, Nicolin Chen wrote: > > > + /* Check if the opposite FRDE is also disabled */ > > + if (!(tx ? rcsr & FSL_SAI_CSR_FRDE : tcsr & FSL_SAI_CSR_FRDE)) { > > I've applied this since it's a fix but this is *not* a triumph of > legibility, the ternery operator is often not helpful. It looks like I've got a bad habit again. I'll be careful next time. Thank you for reminding me, Nicolin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists