[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140415.150950.2105729446204659132.davem@davemloft.net>
Date: Tue, 15 Apr 2014 15:09:50 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: zhen-hual@...com
Cc: sathya.perla@...lex.com, subbu.seetharaman@...lex.com,
ajit.khaparde@...lex.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet
From: "Li, Zhen-Hua" <zhen-hual@...com>
Date: Tue, 15 Apr 2014 14:45:52 +0800
> From: "Li, Zhen-Hua" <zhen-hual@...com>
>
> In benet driver, netif_device_detach and netif_device_attach should be
> called between rtnl_lock and rtnl_unlock.
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@...com>
This absolutely does not look like a driver specific issue, therefore
I do not want you to make such locking context adjustments only in
your driver.
Do it somewhere generic so that every driver gets the fix, not just
your driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists