linux-kernel - Re: [PATCH 1/1] drivers/pci/pcie/portdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140415002529.GF16058@google.com>
Date:	Mon, 14 Apr 2014 18:25:29 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/pci/pcie/portdrv_pci.c: coding style fixes

On Sun, Apr 13, 2014 at 09:49:34AM +0200, Fabian Frederick wrote:
> Move __initdata before equal sign
> printk(KERN_WARNING converted to pr_warn
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/pci/pcie/portdrv_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 0d8fdc4..14eb431 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -402,7 +402,7 @@ static int __init dmi_pcie_pme_disable_msi(const struct dmi_system_id *d)
>  	return 0;
>  }
>  
> -static struct dmi_system_id __initdata pcie_portdrv_dmi_table[] = {
> +static struct dmi_system_id pcie_portdrv_dmi_table[] __initdata = {
>  	/*
>  	 * Boxes that should not use MSI for PCIe PME signaling.
>  	 */
> @@ -429,7 +429,7 @@ static int __init pcie_portdrv_init(void)
>  
>  	retval = pcie_port_bus_register();
>  	if (retval) {
> -		printk(KERN_WARNING "PCIE: bus_register error: %d\n", retval);
> +		pr_warn("PCIE: bus_register error: %d\n", retval);

Hi Fabian,

Can you do similar printk conversions for everything in drivers/pci,
so we do it all at once?  I think there are a few left that could be
converted to dev_info() or similar, so watch for those, too.

Bjorn

>  		goto out;
>  	}
>  	retval = pci_register_driver(&pcie_portdriver);
> -- 
> 1.8.3.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/