linux-kernel - Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534D9517.9080701@hp.com>
Date:	Tue, 15 Apr 2014 14:22:47 -0600
From:	Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@...com>
To:	Jan Kara <jack@...e.cz>
CC:	T Makphaibulchoke <tmac@...com>, tytso@....edu,
	adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, aswin@...com
Subject: Re: [PATCH v2] fs/ext4: increase parallelism in updating ext4 orphan
 list

On 04/15/2014 11:25 AM, Jan Kara wrote:
>   I have checked the source and I didn't find many places where i_mutex was
> not held. But maybe I'm wrong. That's why I wanted to see the patch where
> you are using i_mutex instead of hashed mutexes and which didn't perform
> good enough.
> 

I've attached two patches.  The first one, 0001-Orphan-patch-using-i_mutex-and-removing-s_orphan_loc.patch, is the one you requested, using i_mutex and removing the s_orphan_lock.  The second one, 0001-Adding-code-to-collect-i_mutex-usage-during-orphan.patch, with the code to collect statistics on the number of orphan operations with and without holding i_mutex, in case you are also interested, can be applied on top of the first patch.

Please note that these two patches is meant for data collection only, as the code is quite of submittal quality.

Please also let me know if you have any further comments or suggestion.  I'll hold submitting for a couple more days.

> 
> 								Honza
>

Thanks,
Mak.

View attachment "0001-Orphan-patch-using-i_mutex-and-removing-s_orphan_loc.patch" of type "text/x-patch" (8653 bytes)

View attachment "0001-Adding-code-to-collect-i_mutex-usage-during-orphan.patch" of type "text/x-patch" (3438 bytes)