linux-kernel - Re: Fwd: Re: [PATCH v2] input: misc: Add driver for Intel Bay Trail GPIO buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140415222001.GA2431@amd.pavel.ucw.cz>
Date:	Wed, 16 Apr 2014 00:20:01 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Zhu, Lejun" <lejun.zhu@...ux.intel.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	yu-sheng Chen <verylong2@...il.com>
Subject: Re: Fwd: Re: [PATCH v2] input: misc: Add driver for Intel Bay
 Trail GPIO buttons

Hi!
> 
> Input: misc - Add driver for Intel Bay Trail GPIO buttons
> 
> From: Lejun Zhu <lejun.zhu@...ux.intel.com>
> 
> This patch adds support for the GPIO buttons on some Intel Bay Trail
> tablets originally running Windows 8. The ACPI description of these
> buttons follows "Windows ACPI Design Guide for SoC Platforms".

Hmm. Is it time for x86 to adopt device tree? Because this is 200
lines of C code which should really have been 10 lines of .dts...

> +
> +/*
> + * Some of the buttons like volume up/down are auto repeat, while others
> + * are not. To support both, we register two platform devices, and put
> + * buttons into them based on whether the key should be auto repeat.
> + */
> +#define BUTTON_TYPES	2
> +
> +struct soc_button_data {
> +	struct platform_device *children[BUTTON_TYPES];
> +};

Would it be possible to extend device description so that this hack is
not needed?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/