linux-kernel - Re: [PATCH] mfd: mc13xxx-core: Initialize the lock prior to using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140415225250.GB24070@n2100.arm.linux.org.uk>
Date:	Tue, 15 Apr 2014 23:52:51 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Fabio Estevam <festevam@...il.com>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org,
	linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] mfd: mc13xxx-core: Initialize the lock prior to using
	it

On Tue, Apr 15, 2014 at 07:43:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> warning.

I'd suggest... "which will trigger a kernel oops" because that's what
you got - it killed the IRQ thread, which then caused a few other
problems along the way.

> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
> 
> Suggested-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Patch looks good, and should fix the reported issue... so with the above
description fixed,

Acked-by: Russell King <rmk+kernel@....linux.org.uk>

Thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/