linux-kernel - Re: [PATCH v2] Drivers/PCI: Logging clean-up [1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1397626875.15177.3.camel@joe-AO722>
Date:	Tue, 15 Apr 2014 22:41:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, Bjorn <bhelgaas@...gle.com>
Subject: Re: [PATCH v2] Drivers/PCI: Logging clean-up [1]

On Wed, 2014-04-16 at 07:37 +0200, Fabian Frederick wrote:
> -Convert printk(KERN_WARNING|KERN_ERR|KERN_INFO to pr_foo()
> -Define pr_fmt where it doesn't break existing format.
[]
>  (other ones ?)
[]
> diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
[]
> @@ -830,8 +831,8 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	err = pci_enable_device(pdev);
>  	if (err) {
> -		printk(KERN_ERR MY_NAME ": cannot enable PCI device %s (%d)\n",
> -			pci_name(pdev), err);
> +		pr_err("cannot enable PCI device %s (%d)\n", pci_name(pdev),
> +		       err);

trivia:

My preference is to keep format and argument
on a single line where possible and on
separate lines when not.

		pr_err("cannot enable PCI device %s (%d)\n",
		       pci_name(pdev), err);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/