linux-kernel - Re: [PATCH] staging: dgrp: Fixed coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <002d01cf5949$1c273550$54759ff0$%han@samsung.com>
Date:	Wed, 16 Apr 2014 16:54:35 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Dan Carpenter' <dan.carpenter@...cle.com>,
	'Thomas Tanaka' <thomas.tanaka@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	bernat.ada@...il.com, keescook@...omium.org,
	peter.p.waskiewicz.jr@...el.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] staging: dgrp: Fixed coding style

On Wednesday, April 16, 2014 4:44 PM, Dan Carpenter wrote:
> On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote:
> > Fixed line width > 80
> >
> > Signed-off-by: Thomas Tanaka <thomas.tanaka@...il.com>
> > ---
> >  drivers/staging/dgrp/dgrp_sysfs.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
> > index 2f9345f..93803e0c 100644
> > --- a/drivers/staging/dgrp/dgrp_sysfs.c
> > +++ b/drivers/staging/dgrp/dgrp_sysfs.c
> > @@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
> >  	ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
> >  		&dgrp_global_settings_attribute_group);
> >  	if (ret) {
> > -		pr_alert("%s: failed to create sysfs global settings device attributes.\n",
> > -			__func__);
> > +		pr_alert("%s: failed to create sysfs global settings device
> > +			 attributes.\n", __func__);
> 
> The original was fine.  It doesn't cause a checkpatch.pl warning.  The
> new one is buggy and won't print the correct text.

Yes, right. In this case, it prints some tabs between 'device'
and 'attributes.' So, this patch should be NAKed.

Best regards,
Jingoo Han

> 
> regards,
> dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/